Fix NumberFormatter ignoring an explicit 0 decimals - #179
Open
CasperBE wants to merge 1 commit into
Open
Conversation
The check for the optional $decimals argument used a loose comparison, so an explicit 0 was treated the same as null and fell back to auto-detecting the decimals present in the input. NumberFormatter::format(12.345, 0) returned '12.345' instead of '12'. The NumberFormatterTest was never executed: it sits at the root of tests/, while phpunit.xml only registered the tests/Write and tests/Read directories. Added a 'unit' testsuite covering the root so the new cases actually run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for the optional $decimals argument used a loose comparison, so an explicit 0 was treated the same as null and fell back to auto-detecting the decimals present in the input. NumberFormatter::format(12.345, 0) returned '12.345' instead of '12'.
The NumberFormatterTest was never executed: it sits at the root of tests/, while phpunit.xml only registered the tests/Write and tests/Read directories. Added a 'unit' testsuite covering the root so the new cases actually run.