Repository navigation
napi: build the musl addons against a dynamic C runtime and smoke them on Alpine - #9
Merged
Merged
Conversation
…m on Alpine The musl targets link the C runtime statically by default, which cannot go into a cdylib: cargo refused both musl builds. The addon alone is built with -crt-static, as napi-rs does. The smoke moves to napi/scripts/smoke.cjs so the musl builds can run it inside node:22-alpine on the same runner.
…atform package is missing
A musl cdylib linked on the Ubuntu runner with musl-tools did not load in a musl Node. The same crate built in rust:1-alpine with -crt-static loads in node:22-alpine and installs real packages (verified locally on arm64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both musl targets failed in the first napi run: cargo cannot produce a cdylib with musl's default static C runtime. The addon is now built with
-C target-feature=-crt-staticon musl, as napi-rs does. The smoke script moves tonapi/scripts/smoke.cjs; the musl builds run it insidenode:22-alpineon the same runner.