Deduplicate object request fields' handling#4007
Open
cthulhu-rider wants to merge 3 commits into
Open
Conversation
Check once and reuse wherever needed. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Stale since e4a034c. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Check once and reuse wherever needed. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4007 +/- ##
==========================================
- Coverage 27.80% 27.80% -0.01%
==========================================
Files 681 681
Lines 46763 46676 -87
==========================================
- Hits 13003 12978 -25
+ Misses 32522 32468 -54
+ Partials 1238 1230 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
carpawell
reviewed
Jun 4, 2026
| return code, nil | ||
| } | ||
|
|
||
| func checkRequiredObjectAddress(m *protorefs.Address) (cid.ID, oid.ID, string) { |
Member
There was a problem hiding this comment.
why returning string, not an error?
Contributor
Author
There was a problem hiding this comment.
it's written to status message which is of string type
| // first object not defined, unexpected, do not attach any header | ||
| } | ||
| } | ||
| case *protoobject.SearchRequest: |
Member
There was a problem hiding this comment.
why dont we have SearchV2Request there? it also has cID
Contributor
Author
There was a problem hiding this comment.
it's never been there 🤷♂️
| } | ||
|
|
||
| func WithOID(v *oid.ID) Option { | ||
| func WithOID(v oid.ID) Option { |
Contributor
Author
There was a problem hiding this comment.
it could be, but i decided to change everything related to CID/OID in one change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.