Skip to content

DWDT-3-update-ci-build-file #50

Closed
2 of 2 issues completed
Closed

Description

@nspalo

Update the CI Build Process

  • Update the CI trigger
on:
  pull_request:
    # Validation runs when a PR is created targeting 'development' or 'master'.
    # This checks code quality and tests.
    branches: [ "master", "development" ] 

  push:
    # Integration/Deployment runs ONLY when code lands on the main branch.
    # We remove 'development' from the push trigger.
    branches: [ "master" ]
  • Update the CI flow
jobs:

  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout Code
      uses: actions/checkout@v3 # <<< RECOMMENDED_CHANGE_START >>>
      # Uses: actions/checkout@v4 # Recommended: Use v4 for stability and latest features
      uses: actions/checkout@v4
      # <<< RECOMMENDED_CHANGE_END >>>
      
    # Docker Credentials
    - name: Docker Login
      # <<< RECOMMENDED_CHANGE_START >>>
      uses: docker/login-action@v3 # Recommended: Use action for secure login
      with:
        username: ${{ secrets.DOCKER_USER }}
        password: ${{ secrets.DOCKER_KEY }}
      # <<< RECOMMENDED_CHANGE_END >>>
      # REMOVED: env: and run: | docker login -u $DOCKER_USER -p $DOCKER_KEY

    # Setting Script Permissions
    - name: Setting up Permissions
      run: |
        chmod +x -R ./scripts/*.sh
        # mkdir -p ./storage/logs/ ./bootstrap/cache/ # Skipping, there is no dir structure yet
        # chmod 777 ./storage/ ./bootstrap/cache -R  # Yup, same with this one

    # Building Docker Images and Service Containers
    - name: Building Docker Images
      run: ./scripts/build.sh

    # Docker Containers
    - name: Start Docker Containers
      run: ./scripts/up.sh -d

    # Teardown routine, clean after yourself!
    - name: Teardown, stopping and removing services
      # <<< RECOMMENDED_CHANGE_START >>>
      if: always() # Recommended: Ensures containers are cleaned up even if previous steps fail
      # <<< RECOMMENDED_CHANGE_END >>>
      run: ./scripts/down.sh -v

    # REMOVED: All the commented-out TODO sections for clarity and modernization.

Metadata

Metadata

Assignees

Labels

developmentImprovements or additions to documentationenhancementNew feature or request

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions