Skip to content

Configurable device info #20

Description

@DarkCat09

There's a probability that our static useragent will be banned (though afaik MAX hasn't blocked anyone by UA yet)

vkmax/vkmax/client.py

Lines 175 to 185 in 4e7d820

"userAgent": {
"deviceType": "WEB",
"locale": "ru_RU",
"osVersion": "macOS",
"deviceName": "vkmax Python",
"headerUserAgent": USER_AGENT,
"deviceLocale": "ru-RU",
"appVersion": APP_VERSION,
"screen": "956x1470 2.0x",
"timezone": "Asia/Vladivostok"
},

It may be suspicious when a user sign-ins with Asia/Vladivostok timezone if previously they never was in that timezone. Same for osVersion key. And deviceName has kinda the most careless default value.

Letting a developer set any device info is not an option too. Also take into account that MAX silently ignores invalid handshake packets.

I think we should create several enums with possible values for user-agent parts

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions