fix(config): avoid exporting persistent allow-scripts - #9913
Open
Fnine59 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
A user or global
.npmrccan defineallow-scriptsas persistent policy.setEnvs()currently carries that non-default value into lifecycle child processes asnpm_config_allow_scripts. If a lifecycle script runs a nested project-scopednpm install, the inner process treats the inherited value as an environment override and rejects it withEALLOWSCRIPTSinstead of reloading the policy from its persistent config source.Mark
allow-scriptsas non-exportable. This only preventssetEnvs()from synthesizing the lifecycle environment variable; it does not remove an explicitly supplied environment value or change how the outer command reads its config. Pacote's git-preparation environment filtering and #9783 are outside this change.The regression test models a user-level value in the inherited config chain and verifies that lifecycle scripts do not receive
npm_config_allow_scripts.AI assistance
OpenAI Codex assisted with analysis, implementation, and test design. The patch was verified with the focused regression, the complete
@npmcli/configsuite, lint, and template checks.References
Fixes #9912