fix: keep dry-run output valid json - #9823
Merged
Merged
Conversation
Suppress human-readable reify diffs when JSON output is requested so stdout remains parseable. Fixes #8565 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00
reggi
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-runand--longcommands--dry-run --jsonand--long --jsonBackground
Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON.
Related to #8567, with the regression coverage requested during review.
Testing
tap --no-coverage --no-check-coverage test/lib/utils/reify-output.jseslint lib/utils/reify-output.js test/lib/utils/reify-output.jsFixes #8565