fix: don't call chmod if the bin already has execution permission - #171
Merged
Conversation
owlstronaut
approved these changes
May 13, 2026
Merged
owlstronaut
pushed a commit
that referenced
this pull request
May 15, 2026
🤖 I have created a release *beep* *boop* --- ## [7.0.0](v6.0.0...v7.0.0) (2026-05-15) ###⚠️ BREAKING CHANGES * `bin-links` now supports node `^22.22.2 || ^24.15.0 || >=26.0.0` * template-oss-apply * man pages listed in a package's `man` field are no longer linked into the system man path on global install. `man <pkg>` will no longer work for newly installed global packages. Use the package's own help facilities (e.g. `npm help <cmd>`) instead. ### Features * [`0d66567`](0d66567) [#172](#172) bump to new node engine range (@owlstronaut) * [`c0aaffc`](c0aaffc) [#172](#172) template-oss-apply (@owlstronaut) * [`2612e67`](2612e67) [#163](#163) stop installing man pages for global installs (@owlstronaut) ### Bug Fixes * [`ab6bf0d`](ab6bf0d) [#173](#173) use directory-boundary checks for bin ownership validation (@owlstronaut) * [`6049f08`](6049f08) [#171](#171) don't call `chmod` if the bin already has execution permission (@felipecrs) ### Dependencies * [`af7684c`](af7684c) [#172](#172) `write-file-atomic@8.0.0` * [`a09e74a`](a09e74a) [#172](#172) `read-cmd-shim@7.0.0` * [`93ec1ba`](93ec1ba) [#172](#172) `proc-log@7.0.0` * [`5961e1f`](5961e1f) [#172](#172) `npm-normalize-package-bin@6.0.0` * [`47c5a72`](47c5a72) [#172](#172) `cmd-shim@9.0.0` ### Chores * [`0919da0`](0919da0) [#172](#172) template-oss-apply (@owlstronaut) * [`897720a`](897720a) [#172](#172) bumping @npmcli/template-oss from 4.30.0 to 5.1.0 (@owlstronaut) * [`0ff0be3`](0ff0be3) [#175](#175) template-oss-apply (@owlstronaut) * [`f02cef9`](f02cef9) [#163](#163) template-oss-apply (@owlstronaut) * [`88eda3f`](88eda3f) bump @npmcli/eslint-config from 5.1.0 to 6.0.0 (#157) (@dependabot[bot]) * [`0f07dcd`](0f07dcd) [#161](#161) bump @npmcli/template-oss from 4.28.1 to 4.29.0 (#161) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fixBinfunction unconditionally calledchmodon every bin file, even when the file already had the required permissions. This causedEPERM: operation not permitted, chmoderrors in environments where the current user is not the file owner but the file already has the correct permissions.This fixes it so that before calling
chmod, the functionstats the file and checks whether it already satisfies the requested mode. If it does, it skips thechmodcall entirely.References
Fixes #145
Refs pnpm/pnpm#3699 (comment)