Require VST3 double-precision validation - #150
Closed
satoshi-assistant wants to merge 2 commits into
Closed
Conversation
Steinberg's validator treats unsupported 64-bit audio processing as a successful skip, so enforce WRAC's sample-precision contract from the validator output.
Integrate the extracted validator configuration and MIDI output changes while preserving the explicit double-precision validation gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Steinberg's validator exits successfully when a plugin reports that 64-bit audio processing is unsupported. WRAC needs a stricter contract: VST3 wrappers must preserve the host's sample precision.
Verification
cargo test -p wrac_build_opscargo xtask quality