Enforce the WRAC plugin layout contract - #148
Merged
satoshi-szk merged 2 commits intoJul 15, 2026
Merged
Conversation
Identify plugins from src-plugin/Cargo.toml so missing or misplaced WRAC manifests fail explicitly in xtask and CI instead of being skipped or accepted through a fallback.
Keep the layout contract only where plugin authors configure a project, with one essential line per setup guide and no duplicate schema-reference text.
satoshi-szk
marked this pull request as ready for review
July 15, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
<plugin-root>/src-plugin/Cargo.toml.wrac-plugin.tomlat<plugin-root>/src-plugin/wrac-plugin.tomland reject manifests at the plugin root or other source directories.wrac_manifest::discover_manifest.cargo xtask qualityso CI reports violations explicitly.Why
Manifest-based discovery silently skipped missing manifests and accepted a legacy plugin-root location. A fixed structural marker makes ordinary Cargo packages remain outside WRAC discovery while turning invalid WRAC plugin layouts into actionable errors.
Validation
cargo test -p wrac_manifest -p wrac_build_opscargo test -p wrac_build_ops context::testscargo xtask qualitycargo check --workspace --all-targetsgit diff --check