Repository navigation
Regenerate the API client and record the payment list endpoints - #170
Open
giordano-lucas wants to merge 2 commits into
Open
giordano-lucas wants to merge 2 commits into
giordano-lucas wants to merge 2 commits into
Conversation
GET /payments and GET /payments/connection (nottelabs/monorepo#5047) serve the console Payments page; a CLI command for them is a follow-up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge; no actionable issues were found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfails CI: the staging API moved since the last client regeneration (#167). This brings in the regenerated client from the bump bot's #169 (commit496ca3b) and the coverage entries #169 is missing. #169 can't take a manual commit because the bump workflow force-pushes its branch on every run.internal/api/client.gen.go, unchanged from chore: regenerate API client from latest OpenAPI spec #169.GET /paymentsandGET /payments/connection(nottelabs/monorepo#5047) are recorded asskip. They serve the console Payments page; #5047 names a laternotte payment listas the CLI follow-up.check-endpointsfails, as it does on chore: regenerate API client from latest OpenAPI spec #169.This unblocks #168 (
notte vaults connect), whosebuildjob fails on the same generated-code check.go build ./...,go test -race -short ./...andgolangci-lintpass.check-endpointsneeds a staging key I don't have, so CI runs it.🤖 Generated with Claude Code