Skip to content

Regenerate the API client and record the payment list endpoints - #170

Open
giordano-lucas wants to merge 2 commits into
mainfrom
chore/regenerate-api-client-payments
Open

giordano-lucas wants to merge 2 commits into
mainfrom
chore/regenerate-api-client-payments

Conversation

@giordano-lucas

Copy link
Copy Markdown
Member

main fails CI: the staging API moved since the last client regeneration (#167). This brings in the regenerated client from the bump bot's #169 (commit 496ca3b) and the coverage entries #169 is missing. #169 can't take a manual commit because the bump workflow force-pushes its branch on every run.

This unblocks #168 (notte vaults connect), whose build job fails on the same generated-code check.

  • Checked locally: go build ./..., go test -race -short ./... and golangci-lint pass.
  • Not checked locally: check-endpoints needs a staging key I don't have, so CI runs it.

🤖 Generated with Claude Code

github-actions Bot and others added 2 commits November 4, 2026 01:56
GET /payments and GET /payments/connection (nottelabs/monorepo#5047) serve
the console Payments page; a CLI command for them is a follow-up.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds generated client support for the two payment GET endpoints and records why the CLI skips them.

  • Go callers can request filtered pages of payment records.
  • Go callers can fetch wallet connection status for a chosen mode.
  • Generated enum values now carry their type names.

No actionable issues found. The staging-dependent checks were not run during this review.

Reviews (1) · Last reviewed commit: "Record the payment list and wallet statu..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant