Repository navigation
chore: regenerate API client from latest OpenAPI spec - #166
Conversation
andreakiro
left a comment
There was a problem hiding this comment.
Auto-approved: scheduled API client regeneration.
[Medium impact] The changes affect callers of the generated session API client. The PR appears safe to merge, with a non-blocking text-output issue.
|
| // RecordSession Whether saved session replay is enabled. Defaults to true. | ||
| RecordSession *bool `json:"record_session,omitempty"` | ||
| RecordSession *bool `json:"record_session,omitempty"` | ||
| SecretProxy *SecretProxySummary `json:"secret_proxy,omitempty"` |
There was a problem hiding this comment.
Certificate fingerprints become unreadable
For sessions with ca_sha256 set, the new SecretProxy field makes text-mode sessions status print a pointer address instead of the certificate fingerprints. printSessionStatus dereferences the outer pointer, then prints the whole struct with %v, leaving the nested CaSha256 pointer unreadable. Format the summary’s fields separately so users can read the fingerprints. JSON output is unaffected.
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/api/client.gen.go
Line: 4929
Comment:
**Certificate fingerprints become unreadable**
For sessions with `ca_sha256` set, the new `SecretProxy` field makes text-mode `sessions status` print a pointer address instead of the certificate fingerprints. `printSessionStatus` dereferences the outer pointer, then prints the whole struct with `%v`, leaving the nested `CaSha256` pointer unreadable. Format the summary’s fields separately so users can read the fingerprints. JSON output is unaffected.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Automated regeneration of the generated API client (
internal/api,internal/cmd/*_flags.gen.go) from the latest OpenAPI spec.Last regenerated: 2026-11-04 01:27 UTC