Skip to content

chore: regenerate API client from latest OpenAPI spec - #166

Merged
giordano-lucas merged 1 commit into
mainfrom
chore/regenerate-api-client
Nov 4, 2026
Merged

giordano-lucas merged 1 commit into
mainfrom
chore/regenerate-api-client

Conversation

@giordano-lucas

Copy link
Copy Markdown
Member

Automated regeneration of the generated API client (internal/api, internal/cmd/*_flags.gen.go) from the latest OpenAPI spec.

Last regenerated: 2026-11-04 01:27 UTC

@andreakiro andreakiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: scheduled API client regeneration.

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect callers of the generated session API client.

The PR appears safe to merge, with a non-blocking text-output issue.

Fix All in Claude CodeFindings

  1. P2 Certificate fingerprints become unreadable ▶
Fix with agent prompt
### Issue 1
internal/api/client.gen.go:4929
For sessions with `ca_sha256` set, the new `SecretProxy` field makes text-mode `sessions status` print a pointer address instead of the certificate fingerprints. `printSessionStatus` dereferences the outer pointer, then prints the whole struct with `%v`, leaving the nested `CaSha256` pointer unreadable. Format the summary’s fields separately so users can read the fingerprints. JSON output is unaffected.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Updates the generated API client for secret proxies.

  • Session requests can route chosen hosts through a secret proxy.
  • Session responses include a summary of the secret proxy.

Reviews (1) · Last reviewed commit: "chore: regenerate API client from latest..." · Reviewed by Greptile

// RecordSession Whether saved session replay is enabled. Defaults to true.
RecordSession *bool `json:"record_session,omitempty"`
RecordSession *bool `json:"record_session,omitempty"`
SecretProxy *SecretProxySummary `json:"secret_proxy,omitempty"`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Certificate fingerprints become unreadable

For sessions with ca_sha256 set, the new SecretProxy field makes text-mode sessions status print a pointer address instead of the certificate fingerprints. printSessionStatus dereferences the outer pointer, then prints the whole struct with %v, leaving the nested CaSha256 pointer unreadable. Format the summary’s fields separately so users can read the fingerprints. JSON output is unaffected.

Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/api/client.gen.go
Line: 4929

Comment:
**Certificate fingerprints become unreadable**

For sessions with `ca_sha256` set, the new `SecretProxy` field makes text-mode `sessions status` print a pointer address instead of the certificate fingerprints. `printSessionStatus` dereferences the outer pointer, then prints the whole struct with `%v`, leaving the nested `CaSha256` pointer unreadable. Format the summary’s fields separately so users can read the fingerprints. JSON output is unaffected.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code

@giordano-lucas
giordano-lucas merged commit 181ac69 into main Nov 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants