feat(heo): improve day-night toggle - #4471
Merged
tangly1024 merged 2 commits intoAug 29, 2026
Merged
Conversation
|
@amansamani is attempting to deploy a commit to the tangly1024's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for notionnext-netlify ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tangly1024
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HEO theme's current dark mode button has a simple icon-based presentation and does not provide a clear toggle-style interaction.
Solution
Improve the HEO theme's day/night mode toggle with a more intuitive sliding toggle UI.
useGlobal().toggleDarkMode()logic.<button>for better accessibility.aria-labelandaria-pressedattributes.cRef/handleChangeDarkModeinterface used by the mobile drawer.Benefits
Changes
themes/heo/components/DarkModeButton.jstoggleDarkMode()function fromuseGlobal().aria-labelandaria-pressedaccessibility attributes.Testing
yarn lintgit diff --checkDocumentation
Closes #2236