Skip to content

benchmark,tools: fix napi benchmarks on GHA #66423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nigrosimone wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

benchmark,tools: fix napi benchmarks on GHA #66423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,22 @@ jobs:
run: |
nix-shell \
-I nixpkgs=./tools/nix/pkgs.nix \
--pure --keep SCCACHE_LOCAL_RW_MODE \
--pure --keep SCCACHE_LOCAL_RW_MODE --keep CATEGORIES \
--arg useSeparateDerivationForV8 true \
--arg withPerfetto ${{ matrix.perfetto || false }} \
--arg loadJSBuiltinsDynamically false \
--arg ccache '(import <nixpkgs> {}).sccache' \
--arg devTools '[]' \
--arg benchmarkTools '[]' \
--run '
set -e
make build-ci -j4 V=1
# The napi benchmarks load addons of their own, both binaries use these.
if [[ " $CATEGORIES " == *" napi "* ]]; then make bench-addons-build; fi
'
env:
SCCACHE_LOCAL_RW_MODE: READ_ONLY
CATEGORIES: ${{ inputs.category }}

- name: Run benchmark
run: |
Expand Down
6 changes: 5 additions & 1 deletion benchmark/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,11 @@ module.exports = {
return process.binding(bindingName);
}
},
buildType: process.features.debug ? 'Debug' : 'Release',
// As in test/common: a --debug-node build is still a Release build, and its
// addons are in build/Release.
buildType: process.config.target_defaults ?
process.config.target_defaults.default_configuration :
'Release',
createBenchmark(fn, configs, options) {
return new Benchmark(fn, configs, options);
},
Expand Down
Loading