Skip to content

doc,src,test: fix typos in code comments - #66218

Closed
aguashui wants to merge 1 commit into
nodejs:mainfrom
aguashui:fix-comment-typos
Closed

aguashui wants to merge 1 commit into
nodejs:mainfrom
aguashui:fix-comment-typos

Conversation

@aguashui

@aguashui aguashui commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Correct miscellaneous spelling and grammar typos.

Signed by Noah Webber noah.webber@pmg.com
Assisted by Gemini

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/performance
  • @nodejs/quic
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@aguashui aguashui changed the title doc,src,test: fix typos in code comments Kitchen sink changes Sep 22, 2026
Correct miscellaneous spelling and grammar typos in code comments and
documentation. No code identifiers or runtime logic were modified.

Signed-off-by: Noah Webber <noah.webber@pmg.com>
Assisted-by: Gemini
@aguashui aguashui changed the title Kitchen sink changes doc,src,test: fix typos in code comments Sep 23, 2026
@aguashui
aguashui marked this pull request as ready for review September 23, 2026 22:53
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (c0ed28f) to head (0009485).
⚠️ Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66218      +/-   ##
==========================================
- Coverage   90.29%   90.28%   -0.01%     
==========================================
  Files         790      789       -1     
  Lines      272883   272909      +26     
  Branches    52118    52111       -7     
==========================================
+ Hits       246387   246405      +18     
- Misses      16943    16968      +25     
+ Partials     9553     9536      -17     
Files with missing lines Coverage Δ
lib/internal/bootstrap/realm.js 96.99% <100.00%> (ø)
lib/internal/main/embedding.js 91.89% <100.00%> (ø)
lib/internal/modules/esm/translators.js 97.56% <100.00%> (ø)
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
src/cppgc_helpers.h 60.00% <ø> (-30.00%) ⬇️
src/dataqueue/queue.cc 65.98% <ø> (ø)
src/fs_event_wrap.cc 76.92% <ø> (ø)
src/node.cc 77.13% <ø> (ø)
src/node_file.cc 75.13% <ø> (-0.06%) ⬇️
src/node_http2.cc 82.03% <ø> (-0.05%) ⬇️
... and 2 more

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2026
panva pushed a commit that referenced this pull request Sep 25, 2026
Correct miscellaneous spelling and grammar typos in code comments and
documentation. No code identifiers or runtime logic were modified.

Signed-off-by: Noah Webber <noah.webber@pmg.com>
Assisted-by: Gemini
PR-URL: #66218
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@panva

panva commented Sep 25, 2026

Copy link
Copy Markdown
Member

Landed in 96ee81c

@panva panva closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account author ready PRs with CI started, the required approvals, and no outstanding review comments. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants