Skip to content

fix: allow empty regex match in window rules - #65

Open
Yocraft-2000 wants to merge 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/empty-regex
Open

fix: allow empty regex match in window rules#65
Yocraft-2000 wants to merge 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/empty-regex

Conversation

@Yocraft-2000

Copy link
Copy Markdown
Contributor

Summary

allow empty regex match in window rules

Motivation

firefox opens its browser toolbox with no title so I want to be able to match this window to make it floating.
I can do it in niri.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Testing

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I initialized and updated the SceneFX submodule where required.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant