feat(screen_recorder): configurable bar glyph per state - #59
Merged
ItsLemmy merged 2 commits intoAug 30, 2026
Merged
Conversation
The bar widget hardcoded its glyph for each state, so the only way to change one was to edit recorder.luau and lose it on the next update. Five settings, one per state the widget renders: unavailable, idle, pending, recording, replaying. Each defaults to the glyph that state already used, and an unset or empty value falls back to the same, so this is a no-op until someone sets one. The case that prompted it: Tabler carries filled variants of most outline icons, so `glyph_recording = "video-filled"` makes the active state read as a solid camera rather than an outline one that differs from idle only by colour. Left out of the defaults deliberately, since that is a taste change rather than a fix. Colours are untouched: recording stays `error`, pending `primary`, replaying `secondary`.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
screen_recorderbar widget hardcodes its glyph for each state, so changing one means editingrecorder.luauand losing it on the next update. This adds five settings, one per state the widget renders:glyph_unavailablevideo-offglyph_idlevideoglyph_pendingvideoglyph_recordingvideoglyph_replayingrepeatEvery default is the glyph that state already used, and an unset or empty value falls back to the same, so this is a no-op until someone sets one. Colours are untouched: recording stays
error, pendingprimary, replayingsecondary.Motivation
Idle and recording both render
videoand differ only by colour. On a busy bar that is easy to miss, and it carries no signal at all for a red/green colour blind user.Tabler ships filled variants of most outline icons, so
glyph_recording = "video-filled"gives a solid camera while recording against an outline one at rest — distinguishable by shape as well as tint.I deliberately left that out of the defaults. Changing what everyone sees is a taste call rather than a fix, and this PR is only about making it reachable.
Type of Change
Related Issue
None.
Testing
noctalia plugins lint screen_recorder— 0 errors, 0 warningspython3 .github/workflows/validate-plugins.py— validated 12 plugin manifest(s), exit 0noctalia-git 5.0.0.r5339— plugin loads with 3 entries, no config warnings withglyph_recording = "video-filled"set via[plugin_settings."noctalia/screen_recorder"]noctalia msg plugin noctalia/screen_recorder:service all toggle; state transitions and the existing settings (codec, qp, audio source, cursor) behave as beforetranslations/en.jsoncarries the new labels only, per the README — other locales are left to Noctalia Translate.Manual Coverage
Tested on niri 26.04, two outputs (3440x1440 + 2560x1440), bar at top. Not tested on other compositors, other bar positions, or non-default scaling — the change is a per-state glyph name lookup with unchanged fallbacks, so it should be independent of all three, but I have not verified that.