Feat/output identity selectors - #100
Open
rogervn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today we can only pin the greeter config to a connector as name. This limits us on monitors we want to set independant of the connector we use. Based on noctalia-dev/noctalia#3754 for noctalia-shell where we added support to match by make, serial number and description using the
zwlr_output_manager_v1extension we do something similar here to be able to match by different names.As in the first one, happy to take feedbacks here on how we can do it differently.
Motivation
We should be able to match by more than the connector as we can change the connector and set different monitors if we have multiple of the same name.
Type of Change
Related Issue
None
Testing
Ran locally the outputs command:
Copied the greeter and compositor to a VM and ran it looking for the logs for pinned output:
Whilst checking for logs, changed the config to multiple values, including the VM outputs for make, model and connector. Only the exact matches returned the log.
Manual Coverage
just run/just run-local(dev compositor)Sync Now)programs.noctalia-greeter)[output].name[output].layout/[output].transformsScreenshots / Videos
None
Checklist
AGENTS.mdandREADME.md.just formatwith clang-format v22+ installed, or this PR has no code changes.Additional Notes