Skip to content

fix(cider): support Umbriel in window probe - #531

Closed
MythosOfs wants to merge 1 commit into
noctalia-dev:mainfrom
MythosOfs:fix/cider-umbriel-window-probe
Closed

fix(cider): support Umbriel in window probe#531
MythosOfs wants to merge 1 commit into
noctalia-dev:mainfrom
MythosOfs:fix/cider-umbriel-window-probe

Conversation

@MythosOfs

Copy link
Copy Markdown

Summary

The cider bridge's probe_cider_window() only handled niri and Hyprland. On an Umbriel session where hyprctl happens to be installed (e.g. after switching compositors), the probe selected the Hyprland branch, hyprctl clients -j failed with HYPRLAND_INSTANCE_SIGNATURE not set, and the probe returned present: false.

Result: the Noctalia bar chip showed the current track for ~600 ms and then hid as "nothing playing", even though Cider was actively playing. Every new track event briefly re-showed the chip before the window probe wiped it again.

Fix

Add an umbriel branch before the hyprctl branch that parses the plain-text output of umbriel windows:

  • Format: [*]app_id<TAB>title<TAB>[tile|float WxH+X+Y], where the leading * marks the focused window
  • Reuses the existing _is_cider_window() matcher (app_id or exact title "cider")

Presence detection is what the plugin needs; focus detection drives notification suppression, which now correctly suppresses toasts only while the Cider window is focused.

Test Plan

  • probe_cider_window() on a live Umbriel session returns {"present": true, "compositor": "umbriel", ...} (previously present: false via the failing Hyprland branch)
  • With the patched bridge running, the Noctalia bar chip stays visible while Cider plays and position keeps ticking (no more "nothing playing" flip)
  • Synthetic parse checks: focused/unfocused cider window, app_id match, title match, non-cider windows ignored
  • niri/Hyprland branches untouched

The bridge's compositor probe only handled niri and Hyprland. On
Umbriel sessions with hyprctl installed, the hyprland branch was
selected, hyprctl failed (no HYPRLAND_INSTANCE_SIGNATURE) and the
probe reported present=false. The Noctalia plugin then hid the
bar chip and showed "nothing playing" ~600ms after every track
event, even while Cider was actively playing.

Add an umbriel branch before the hyprctl one: parse the plain-text
output of 'umbriel windows' ([*]app_id<TAB>title<TAB>[layout ...])
and reuse _is_cider_window for matching.
@github-actions

Copy link
Copy Markdown
Contributor

This pull request was automatically closed because its description no longer contains
every part of the pull request template
that this repository requires.

Missing:

  • the template marker line <!-- noctalia-pr-template:v1 -->
  • the ## Plugin heading
  • the ## What it does heading
  • the ## External dependencies heading
  • the ## Testing heading
  • the ## Screenshots / Videos heading
  • the ## Checklist heading
  • the ## Code review attestation heading
  • the - **Id:** field
  • the - **Noctalia version tested against:** field
  • the - **Plugin API level:** field
  • the checklist entry: New plugin
  • the checklist entry: Update to an existing plugin (version bumped in plugin.toml)
  • the checklist entry: Tested on Niri
  • the checklist entry: Tested on Hyprland
  • the checklist entry: Tested on Sway
  • the checklist entry: Tested on another compositor:
  • the checklist entry: The directory name matches the part of id after the / in plugin.toml exactly.
  • the checklist entry: It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • the checklist entry: README.md follows the README template, documents every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • the checklist entry: I created thumbnail.webp with the thumbnail generator.
  • the checklist entry: version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • the checklist entry: Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • the checklist entry: I did not edit catalog.toml; CI generates it.
  • the checklist entry: This PR touches exactly one plugin directory.
  • the checklist entry: The code is readable and not obfuscated, minified, or generated.
  • the checklist entry: It does not download and execute remote code.
  • the checklist entry: Every network call, filesystem write, and spawned process is something the description above accounts for.
  • the checklist entry: I have the right to publish this code under the license declared in plugin.toml.
  • exactly one checked plugin type: New plugin or Update to an existing plugin
  • at least one checked compositor testing entry

Please add the items listed above back to the description, keeping their exact wording, then
reopen the pull request. Reopening re-runs this check. Draft pull requests may leave boxes
unchecked. Before a pull request is ready for review, exactly one plugin type, at least one
tested compositor, and every item under Checklist and Code review attestation must be checked.

@github-actions github-actions Bot closed this Aug 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CC @dragged9698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant