fix(cider): support Umbriel in window probe - #531
Closed
MythosOfs wants to merge 1 commit into
Closed
Conversation
The bridge's compositor probe only handled niri and Hyprland. On Umbriel sessions with hyprctl installed, the hyprland branch was selected, hyprctl failed (no HYPRLAND_INSTANCE_SIGNATURE) and the probe reported present=false. The Noctalia plugin then hid the bar chip and showed "nothing playing" ~600ms after every track event, even while Cider was actively playing. Add an umbriel branch before the hyprctl one: parse the plain-text output of 'umbriel windows' ([*]app_id<TAB>title<TAB>[layout ...]) and reuse _is_cider_window for matching.
Contributor
|
This pull request was automatically closed because its description no longer contains Missing:
Please add the items listed above back to the description, keeping their exact wording, then |
Contributor
|
CC @dragged9698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cider bridge's
probe_cider_window()only handled niri and Hyprland. On an Umbriel session wherehyprctlhappens to be installed (e.g. after switching compositors), the probe selected the Hyprland branch,hyprctl clients -jfailed withHYPRLAND_INSTANCE_SIGNATURE not set, and the probe returnedpresent: false.Result: the Noctalia bar chip showed the current track for ~600 ms and then hid as "nothing playing", even though Cider was actively playing. Every new track event briefly re-showed the chip before the window probe wiped it again.
Fix
Add an
umbrielbranch before thehyprctlbranch that parses the plain-text output ofumbriel windows:[*]app_id<TAB>title<TAB>[tile|float WxH+X+Y], where the leading*marks the focused window_is_cider_window()matcher (app_id or exact title "cider")Presence detection is what the plugin needs; focus detection drives notification suppression, which now correctly suppresses toasts only while the Cider window is focused.
Test Plan
probe_cider_window()on a live Umbriel session returns{"present": true, "compositor": "umbriel", ...}(previouslypresent: falsevia the failing Hyprland branch)