fix(mihomo-control): avoid CPU budget exhaustion on large API polls (v0.1.4) - #513
Merged
ItsLemmy merged 2 commits intoAug 30, 2026
Merged
Conversation
…v0.1.5) Parse /connections summaries without full json.decode and project oversized /proxies responses through jq so the service keeps publishing state reliably. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
mdj2812/mihomo-controlplugin.toml)What it does
Fixes Mihomo Control becoming unresponsive when polling remote controllers with large
/connectionsor/proxiesAPI responses. The service now scrapes/connectionstotals without a fulljson.decode, and projects oversized/proxiesbodies throughjqinstead of decoding them inline within Noctalia's per-callback CPU budget.External dependencies
jq— used only when a/proxiesresponse exceeds the inline decode size limit, to project group data without exhausting the Luau CPU budget.Testing
Verified against a remote Mihomo controller with large
/connectionsand/proxiespayloads: the service keeps publishing state and the panel stays responsive. Ranlua5.4 mihomo-control/tests/group_order_test.lua.Screenshots / Videos
Not applicable — service-only reliability fix; no visual UI changes in this release.
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.