Skip to content

tailscale: add hide_when_healthy and flag_problem widget settings - #501

Closed
liamwh wants to merge 1 commit into
noctalia-dev:mainfrom
liamwh:tailscale-widget-settings
Closed

tailscale: add hide_when_healthy and flag_problem widget settings#501
liamwh wants to merge 1 commit into
noctalia-dev:mainfrom
liamwh:tailscale-widget-settings

Conversation

@liamwh

@liamwh liamwh commented Aug 27, 2026

Copy link
Copy Markdown

Plugin

  • Id: davemhammer/tailscale
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Adds two independent, opt-in settings to the status widget (both default
false, existing behaviour unchanged):

  • hide_when_healthy — collapse the widget entirely while Tailscale
    is running; it appears only when the daemon is stopped, needs login,
    or is unreachable. For people who want a quiet bar unless something is
    wrong. The /ts launcher provider keeps working while hidden.
  • flag_problem — error-tinted status dot while Tailscale is not
    running, instead of the neutral grey one, shown even with show_counts
    off (a restrained brand-mark + red dot; the detail stays in the manager
    panel the widget opens on click). For permanently-visible widgets that
    should read as an alert.

The two compose: a permanently-visible widget can flag problems, and a
hidden-while-healthy widget only ever appears in a state worth flagging.

External dependencies

None added — pure rendering changes plus two noctalia.getConfig reads.

Testing

  • python3 .github/workflows/scripts/validate-plugins.py — clean.

  • widget.luau parses and runs to the first host-API call under the
    stock luau CLI (the plugin has no test harness; this change mirrors
    the structure of the existing show_counts handling).

  • The equivalent widget behaviour has run daily on the author's machine
    (Niri) via a local patch carrying these two settings; this PR ports it
    onto the current upstream widget structure.

  • Tested on Niri

  • Tested on Hyprland

  • Tested on Sway

  • Tested on another compositor:

  • Noctalia version tested against: v5.0.0-beta.9

  • Plugin API level: unchanged (existing plugin, no new API used)

Screenshots / Videos

No visual change with both settings off (defaults). With flag_problem
on and Tailscale stopped, the widget shows the brand mark plus an
error-red dot; with hide_when_healthy on it is absent entirely while
healthy. Can attach screenshots on request.

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
    (Plugin's existing thumbnail is untouched.)
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

Notes for reviewers

@davemhammer — your call obviously; happy to adjust naming or split into
two PRs if you'd rather take one. Unrelated observation while in here:
translations/en.json carries ok_color/warn_color keys that no
manifest setting references any more (leftovers from a removed colour
setting?) — happy to prune them in a separate PR if you want.

Disclaimer: AI-assisted tooling was used.

Two independent, opt-in status-widget settings (both default false, so
existing behaviour is unchanged):

- hide_when_healthy collapses the widget entirely while Tailscale runs;
  it appears only when the daemon is stopped, needs login, or is
  unreachable — for people who want the bar quiet unless something is
  wrong. The /ts launcher provider still works while hidden.
- flag_problem tints the status dot with the palette's error role while
  Tailscale is not running (and shows that dot even with show_counts
  off), instead of the neutral grey — for permanently-visible widgets
  that should read as an alert.
@github-actions

Copy link
Copy Markdown
Contributor

This pull request was automatically closed because its description no longer contains
every part of the pull request template
that this repository requires.

Missing:

  • the template marker line <!-- noctalia-pr-template:v1 -->
  • the ## Plugin heading
  • the ## What it does heading
  • the ## External dependencies heading
  • the ## Screenshots / Videos heading
  • the ## Checklist heading
  • the ## Code review attestation heading
  • the - **Id:** field
  • the - **Noctalia version tested against:** field
  • the - **Plugin API level:** field
  • the checklist entry: New plugin
  • the checklist entry: Update to an existing plugin (version bumped in plugin.toml)
  • the checklist entry: Tested on Niri
  • the checklist entry: Tested on Hyprland
  • the checklist entry: Tested on Sway
  • the checklist entry: Tested on another compositor:
  • the checklist entry: The directory name matches the part of id after the / in plugin.toml exactly.
  • the checklist entry: It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • the checklist entry: README.md follows the README template, documents every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • the checklist entry: I created thumbnail.webp with the thumbnail generator.
  • the checklist entry: version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • the checklist entry: Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • the checklist entry: I did not edit catalog.toml; CI generates it.
  • the checklist entry: This PR touches exactly one plugin directory.
  • the checklist entry: The code is readable and not obfuscated, minified, or generated.
  • the checklist entry: It does not download and execute remote code.
  • the checklist entry: Every network call, filesystem write, and spawned process is something the description above accounts for.
  • the checklist entry: I have the right to publish this code under the license declared in plugin.toml.
  • exactly one checked plugin type: New plugin or Update to an existing plugin
  • at least one checked compositor testing entry

Please add the items listed above back to the description, keeping their exact wording, then
reopen the pull request. Reopening re-runs this check. Draft pull requests may leave boxes
unchecked. Before a pull request is ready for review, exactly one plugin type, at least one
tested compositor, and every item under Checklist and Code review attestation must be checked.

@github-actions github-actions Bot closed this Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CC @davemhammer

@liamwh

liamwh commented Aug 27, 2026

Copy link
Copy Markdown
Author

Superseded by #503 (same branch; re-opened as a fresh PR with the required template after the initial description was missing required sections).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant