tailscale: add hide_when_healthy and flag_problem widget settings - #501
Closed
liamwh wants to merge 1 commit into
Closed
tailscale: add hide_when_healthy and flag_problem widget settings#501liamwh wants to merge 1 commit into
liamwh wants to merge 1 commit into
Conversation
Two independent, opt-in status-widget settings (both default false, so existing behaviour is unchanged): - hide_when_healthy collapses the widget entirely while Tailscale runs; it appears only when the daemon is stopped, needs login, or is unreachable — for people who want the bar quiet unless something is wrong. The /ts launcher provider still works while hidden. - flag_problem tints the status dot with the palette's error role while Tailscale is not running (and shows that dot even with show_counts off), instead of the neutral grey — for permanently-visible widgets that should read as an alert.
Contributor
|
This pull request was automatically closed because its description no longer contains Missing:
Please add the items listed above back to the description, keeping their exact wording, then |
Contributor
|
CC @davemhammer |
Author
|
Superseded by #503 (same branch; re-opened as a fresh PR with the required template after the initial description was missing required sections). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
davemhammer/tailscaleplugin.toml)What it does
Adds two independent, opt-in settings to the status widget (both default
false, existing behaviour unchanged):hide_when_healthy— collapse the widget entirely while Tailscaleis running; it appears only when the daemon is stopped, needs login,
or is unreachable. For people who want a quiet bar unless something is
wrong. The
/tslauncher provider keeps working while hidden.flag_problem— error-tinted status dot while Tailscale is notrunning, instead of the neutral grey one, shown even with
show_countsoff (a restrained brand-mark + red dot; the detail stays in the manager
panel the widget opens on click). For permanently-visible widgets that
should read as an alert.
The two compose: a permanently-visible widget can flag problems, and a
hidden-while-healthy widget only ever appears in a state worth flagging.
External dependencies
None added — pure rendering changes plus two
noctalia.getConfigreads.Testing
python3 .github/workflows/scripts/validate-plugins.py— clean.widget.luauparses and runs to the first host-API call under thestock
luauCLI (the plugin has no test harness; this change mirrorsthe structure of the existing
show_countshandling).The equivalent widget behaviour has run daily on the author's machine
(Niri) via a local patch carrying these two settings; this PR ports it
onto the current upstream widget structure.
Tested on Niri
Tested on Hyprland
Tested on Sway
Tested on another compositor:
Noctalia version tested against: v5.0.0-beta.9
Plugin API level: unchanged (existing plugin, no new API used)
Screenshots / Videos
No visual change with both settings off (defaults). With
flag_problemon and Tailscale stopped, the widget shows the brand mark plus an
error-red dot; with
hide_when_healthyon it is absent entirely whilehealthy. Can attach screenshots on request.
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.(Plugin's existing thumbnail is untouched.)
versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
licensedeclared inplugin.toml.Notes for reviewers
@davemhammer — your call obviously; happy to adjust naming or split into
two PRs if you'd rather take one. Unrelated observation while in here:
translations/en.jsoncarriesok_color/warn_colorkeys that nomanifest setting references any more (leftovers from a removed colour
setting?) — happy to prune them in a separate PR if you want.
Disclaimer: AI-assisted tooling was used.