Skip to content

Refactor: Remove TUI, Isolate CLI Flags, and Fix Core Bugs#28

Merged
nmdra merged 6 commits into
masterfrom
refactor-tui-and-flags
Jul 21, 2026
Merged

Refactor: Remove TUI, Isolate CLI Flags, and Fix Core Bugs#28
nmdra merged 6 commits into
masterfrom
refactor-tui-and-flags

Conversation

@nmdra

@nmdra nmdra commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Description

This pull request implements the changes outlined in the codebase analysis report to optimize the NoteBrain CLI for agentic usage and fix core inconsistencies.

1. Interactive TUI Removal

  • Removed all interactive TUI features ( components, spinners, live search, result browser).
  • Deleted and directories.
  • Pruned associated dependencies from and .
  • Updated all related documentation (, , and references).

2. CLI Flag Scope Refactoring

  • Isolated Ingest Flags: Moved out of into .
  • Isolated Semantic/Chunk Display Flags: Extracted , , and from into a reusable struct, embedded only where necessary (, , ).
  • Purified the struct to only contain universal flags.
  • Re-architected output formatting in to explicitly rely on the newly defined chunk display flags without forcing defaults on commands that don't use them (e.g. , ).

3. Core Bug Fixes

  • Ingestion Pipeline Default: Ensured defaults to in to enforce short-chunk skipping rules as intended. Fixed associated unit tests.
  • Dead Code: Removed the orphaned package, consolidating completely on the CLI flag framework.
  • FFI Stability: Replaced unsafe hard-coded pagination () with () in to prevent Chroma FFI crashes on large vaults.

All tests have been updated and are passing locally.

@nmdra nmdra self-assigned this Jul 21, 2026
@nmdra nmdra added the enhancement New feature or request label Jul 21, 2026
@nmdra
nmdra merged commit 45961c6 into master Jul 21, 2026
3 checks passed
@nmdra
nmdra deleted the refactor-tui-and-flags branch July 21, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant