Skip to content

fix(api/twapOrder): raise the max TWAP duration to 7 days #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienKervarrec wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(api/twapOrder): raise the max TWAP duration to 7 days #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bc65c2
fix(api/twapOrder): raise the max TWAP duration to 7 days
JulienKervarrec Sep 17, 2026
85913a1
test(api/twapOrder): check the 5 minute to 7 day duration bounds
JulienKervarrec Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/exchange/_methods/twapOrder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const TwapOrderRequest = /* @__PURE__ */ (() => {
/** Whether the order is reduce-only. */
r: v.boolean(),
/** TWAP duration in minutes. */
m: v.pipe(UnsignedInteger, v.minValue(5), v.maxValue(1440)),
m: v.pipe(UnsignedInteger, v.minValue(5), v.maxValue(10080)), // 5 minutes to 7 days
/** Enable random order timing. */
t: v.boolean(),
}),
Expand Down
12 changes: 12 additions & 0 deletions tests/api/exchange/twapOrder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { assertEquals } from "jsr:@std/assert@1";
import { type TwapOrderParameters, TwapOrderRequest } from "@nktkas/hyperliquid/api/exchange";
import { formatPrice, formatSize } from "@nktkas/hyperliquid/utils";
import * as v from "@valibot/valibot";
Expand Down Expand Up @@ -44,3 +45,14 @@ runTest({
schemaCoverage(responseSchema, data);
},
});

Deno.test("twapOrder: duration bounds (5 minutes to 7 days)", () => {
const twapSchema = TwapOrderRequest.entries.action.entries.twap;
const twap = { a: 0, b: true, s: "1", r: false, t: false };
for (const m of [5, 1440, 1441, 10080]) {
assertEquals(v.safeParse(twapSchema, { ...twap, m }).success, true, `m=${m} should be accepted`);
}
for (const m of [4, 10081]) {
assertEquals(v.safeParse(twapSchema, { ...twap, m }).success, false, `m=${m} should be rejected`);
}
});