Refactor PathTargetValue logic, update namespaces - #1
Merged
Merged
Conversation
Refactored PathTargetValue into extensible record types implementing IPathTargetValue. Updated all usages and related logic to use new interface and records. Moved and renamed namespaces for better separation of concerns. Updated using directives, provider lookups, and test code. Replaced .Single()/.SingleOrDefault() with .First()/.FirstOrDefault() in tests. Ensured consistent use of .ConfigureAwait. Updated solution file and added testEnvironments.json. Minor naming refactors. No breaking public API changes; significant internal improvements.
Updated all usages of LookupKey.Get(typeof(T)) and FlavouredLookupKey.Get(typeof(T), ...) to the new generic methods LookupKey.Get<T>() and FlavouredLookupKey.Get<T>(...). Improved type safety and readability in documentation and code samples across provider-lookups.md, provider-variants.md, generating-records.md, getting-started.md, and shared-ancestors.md.
PersistenceGatewayTest now implements IDisposable to reset DeferredInserter for test isolation. Added a sanity check in Flush_AfterDeferredWithExcludePrimaryIds to ensure DeferredInserter is empty. Switched LookupKey to use ConcurrentDictionary for thread-safe access and added missing using directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored PathTargetValue into extensible record types implementing IPathTargetValue. Updated all usages and related logic to use new interface and records. Moved and renamed namespaces for better separation of concerns. Updated using directives, provider lookups, and test code. Replaced .Single()/.SingleOrDefault() with .First()/.FirstOrDefault() in tests. Ensured consistent use of .ConfigureAwait. Updated solution file and added testEnvironments.json. Minor naming refactors. No breaking public API changes; significant internal improvements.