Skip to content

Fix - Should not be a space after -i in SEDOPT - #2

Open
7415963987456321 wants to merge 1 commit into
nickolasburr:masterfrom
7415963987456321:fixes/sedopt
Open

Fix - Should not be a space after -i in SEDOPT#2
7415963987456321 wants to merge 1 commit into
nickolasburr:masterfrom
7415963987456321:fixes/sedopt

Conversation

@7415963987456321

Copy link
Copy Markdown

Ran into problems when running make and ./test, the sed option -i should not have a space between -i and ''

  • Fixes the sed expression in the test and install script
  • Alternatively one could also use --in-place=[SUFFIX] instead but I opted to just remove the space

@nickolasburr

Copy link
Copy Markdown
Owner

@7415963987456321 Thank you for the contribution and sorry it's taken so long. This works for GNU sed but will break if using BSD sed, which requires the space after -i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants