chore: Do not forbid extra fields in Pydantic models to fix incosistency between models and current SLE APIs - #221
Merged
Conversation
AlexDanDuna
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
July 15, 2026 16:19
Closed
1 task
spanglerco
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Two tests for the File and Spec clients are failing, since api info now returns operations that are not properly modeled in their Operations:
Log of failed workflow step:
6_Run poetry run pytest --cloud-api-key --enterprise-uri https_test-api.lifecyclesolutions.ni.com --enterprise-api-key .txt
Skip forbidding extra fields in conftest.py to get the tests to run. Thanks to @spanglerco for suggesting the fix.
Why should this Pull Request be merged?
We're aiming to release a patch for SLS from this branch; enforcing that the models match the current SLE APIs, in this old library version, is out of scope.
What testing has been done?
Pipeline passes