Skip to content

feat: DFS support for test result ID, column name queries, and interactive queries - #164

Merged
spanglerco merged 3 commits into
masterfrom
users/pspangle/tid
Dec 1, 2025
Merged

spanglerco merged 3 commits into
masterfrom
users/pspangle/tid

Conversation

@spanglerco

@spanglerco spanglerco commented Oct 20, 2025 •

Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Add a test_result_id field to all metadata models (create, read, and modify). Add an interactive field to the query tables request model. Document the ability to filter tables by test result ID and column names.

Why should this Pull Request be merged?

The DFS client should support new functionality being added to the service.

What testing has been done?

Ran the DFS tests locally against:

  1. The test cluster that has the new functionality
  2. The demo cluster that has the functionality disabled (feature toggle is off)
  3. A local build of the 2025-10 version of the service (before the functionality was added)

Verified that all tests passed. Cases 2 and 3 log a warning that the service doesn't support test result IDs.
Verified that the tests pass in the GitHub workflow without logging the warning about test result ID support.
Verified the built docs look correct, including the reference to the various operations.

Comment thread nisystemlink/clients/dataframe/models/_modify_table_request.py
Comment thread tests/integration/dataframe/test_dataframe.py Outdated
@spanglerco

Copy link
Copy Markdown
Collaborator Author

The service functionality doesn't exist in a release yet. The feature is targeted to 2025-12.

Comment thread tests/integration/dataframe/test_dataframe.py Outdated
@chris468

Copy link
Copy Markdown
Member

The service functionality doesn't exist in a release yet. The feature is targeted to 2025-12.

It's going to be 2026-01.

@spanglerco

Copy link
Copy Markdown
Collaborator Author

@chris468 We've decided to go ahead and submit this change so internal clients can uptake it.

@spanglerco
spanglerco merged commit 468ab06 into master Dec 1, 2025
12 checks passed
@spanglerco
spanglerco deleted the users/pspangle/tid branch December 1, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants