Skip to content

add new module oauth_provider - #184

Open
resmo wants to merge 5 commits into
masterfrom
feature/oauth-provider
Open

resmo wants to merge 5 commits into
masterfrom
feature/oauth-provider

Conversation

@resmo

@resmo resmo commented Aug 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@resmo
resmo force-pushed the feature/oauth-provider branch from 38becfb to cd19802 Compare August 16, 2026 16:50
@resmo
resmo force-pushed the master branch 12 times, most recently from 4b5b72e to 618a7d3 Compare August 23, 2026 07:45
@resmo
resmo requested a lite review from Copilot August 23, 2026 21:08
@resmo
resmo marked this pull request as ready for review August 23, 2026 21:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new oauth_provider Ansible module to manage OAuth2 providers in Apache CloudStack, along with an integration test target to validate create/update/disable/delete behavior and idempotence.

Changes:

  • Introduces plugins/modules/oauth_provider.py implementing present/absent workflows via CloudStack API calls.
  • Adds a full integration test target (tests/integration/targets/oauth_provider/) with defaults, dependencies, and task coverage for check mode + idempotence.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
plugins/modules/oauth_provider.py New CloudStack module for registering/updating/deleting OAuth providers, including Ansible docs/examples/return schema.
tests/integration/targets/oauth_provider/tasks/main.yml Integration scenario covering failure cases, check mode behavior, create/update/disable/delete, and idempotence.
tests/integration/targets/oauth_provider/defaults/main.yml Test defaults for redirect URI inputs.
tests/integration/targets/oauth_provider/meta/main.yml Declares dependency on cs_common integration target.
tests/integration/targets/oauth_provider/aliases Adds test target aliases for integration grouping.
Suppressed comments (1)

plugins/modules/oauth_provider.py:246

  • domain is accepted in argument_spec but is never used to scope lookups or sent to the CloudStack API, so it currently has no effect. Either implement domain scoping for list/register/update/delete calls or remove the parameter to avoid a misleading API.
            secret_key=dict(type="str", no_log=True),
            redirect_uri=dict(type="str"),
            enabled=dict(type="bool", default=True),
            domain=dict(type="str"),
            authorized_url=dict(type="str"),
            token_url=dict(type="str", no_log=False),
            details=dict(type="list", elements="dict"),

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +68 to +71
domain:
description:
- Domain the SSL certificate is related to.
type: str
Comment thread plugins/modules/oauth_provider.py Outdated
Comment thread plugins/modules/oauth_provider.py
Comment on lines +2 to +6
- name: setup cleanup
ngine_io.cloudstack.oauth_provider:
name: github
state: absent
register: oauth_provider
resmo and others added 2 commits August 23, 2026 23:23
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@resmo
resmo force-pushed the feature/oauth-provider branch from 33fe830 to a8457de Compare September 13, 2026 09:56
@resmo
resmo force-pushed the feature/oauth-provider branch from a456191 to 2058148 Compare September 14, 2026 07:13
@resmo
resmo force-pushed the feature/oauth-provider branch from 2058148 to 61ae005 Compare September 14, 2026 07:22
@resmo
resmo force-pushed the feature/oauth-provider branch from 61ae005 to 4378149 Compare September 14, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants