Conversation
resmo
force-pushed
the
feature/oauth-provider
branch
from
August 16, 2026 16:50
38becfb to
cd19802
Compare
resmo
force-pushed
the
master
branch
12 times, most recently
from
August 23, 2026 07:45
4b5b72e to
618a7d3
Compare
resmo
marked this pull request as ready for review
August 23, 2026 21:09
There was a problem hiding this comment.
Pull request overview
This pull request adds a new oauth_provider Ansible module to manage OAuth2 providers in Apache CloudStack, along with an integration test target to validate create/update/disable/delete behavior and idempotence.
Changes:
- Introduces
plugins/modules/oauth_provider.pyimplementingpresent/absentworkflows via CloudStack API calls. - Adds a full integration test target (
tests/integration/targets/oauth_provider/) with defaults, dependencies, and task coverage for check mode + idempotence.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
plugins/modules/oauth_provider.py |
New CloudStack module for registering/updating/deleting OAuth providers, including Ansible docs/examples/return schema. |
tests/integration/targets/oauth_provider/tasks/main.yml |
Integration scenario covering failure cases, check mode behavior, create/update/disable/delete, and idempotence. |
tests/integration/targets/oauth_provider/defaults/main.yml |
Test defaults for redirect URI inputs. |
tests/integration/targets/oauth_provider/meta/main.yml |
Declares dependency on cs_common integration target. |
tests/integration/targets/oauth_provider/aliases |
Adds test target aliases for integration grouping. |
Suppressed comments (1)
plugins/modules/oauth_provider.py:246
domainis accepted inargument_specbut is never used to scope lookups or sent to the CloudStack API, so it currently has no effect. Either implement domain scoping for list/register/update/delete calls or remove the parameter to avoid a misleading API.
secret_key=dict(type="str", no_log=True),
redirect_uri=dict(type="str"),
enabled=dict(type="bool", default=True),
domain=dict(type="str"),
authorized_url=dict(type="str"),
token_url=dict(type="str", no_log=False),
details=dict(type="list", elements="dict"),
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+68
to
+71
| domain: | ||
| description: | ||
| - Domain the SSL certificate is related to. | ||
| type: str |
Comment on lines
+2
to
+6
| - name: setup cleanup | ||
| ngine_io.cloudstack.oauth_provider: | ||
| name: github | ||
| state: absent | ||
| register: oauth_provider |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
resmo
force-pushed
the
feature/oauth-provider
branch
from
September 13, 2026 09:56
33fe830 to
a8457de
Compare
resmo
force-pushed
the
feature/oauth-provider
branch
from
September 14, 2026 07:13
a456191 to
2058148
Compare
resmo
force-pushed
the
feature/oauth-provider
branch
from
September 14, 2026 07:22
2058148 to
61ae005
Compare
resmo
force-pushed
the
feature/oauth-provider
branch
from
September 14, 2026 07:40
61ae005 to
4378149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.