Repository navigation
Cap a car at its request maximum only where the car sets it - #759
Open
MikeBishop wants to merge 1 commit into
Open
MikeBishop wants to merge 1 commit into
MikeBishop wants to merge 1 commit into
Conversation
A car reports its request maximum capped at the charger's pilot. Read as a Gen2 TWC briefly offered 6 A going idle, it stayed at 6 until the next read while charging, so the next night's scheduled charge was rated at 6 A and sometimes commanded there before the reading caught up. On our own TWC the pilot is our last offer, so a car read under a low offer could hold its charging point there. A request maximum is now the car's own only when one source's reading has it below the pilot; otherwise the wiring limit stands. Lifts still go to the TWC's maximum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Tesla reports
charge_current_request_maxcapped at the charger's pilot, so it's the car's own AC maximum only when the car, not the charger, is the limit.vehicleMaxAmpstook any reading as the car's own, which caps the car's power share (VehicleEndpoint.maxPower) and the range a car provider commands amps over.What went wrong:
The change:
wiringMaxAmpsPerTWC) stands, and the car clamps a higher rate itself.Evidence:
pytest tests --ignore=tests/API --ignore=tests/integration --ignore=tests/scenarios): 2669 passed, on main f094c7c.Released in 1.4.0 in an earlier form:
TeslaAPIEVSE.maxPowerwas the car's last-read pilot (charger_pilot_current). It applied to cars at home that no TWC serves, so a car on a third-party EVSE read while the pilot was low stayed capped there. The 1.4.1 changelog's existing entry already claims "never the pilot it last saw"; this corrects it to say the car's own maximum is known only where a reading shows it below the pilot.🤖 Generated with Claude Code