Bump sentieon modules - #12983
Open
bagnacan wants to merge 28 commits into
Open
Bump sentieon modules#12983bagnacan wants to merge 28 commits into
bagnacan wants to merge 28 commits into
Conversation
bagnacan
force-pushed
the
bump-sentieon
branch
from
September 17, 2026 06:18
25da62b to
899bbe2
Compare
bagnacan
force-pushed
the
bump-sentieon
branch
from
September 17, 2026 06:29
899bbe2 to
16a5d3e
Compare
bagnacan
force-pushed
the
bump-sentieon
branch
from
September 17, 2026 06:53
16a5d3e to
052e76c
Compare
Member
|
@nf-core-bot fix linting pretty please 🙏 |
Member
|
@nf-core-bot fix linting |
bagnacan
force-pushed
the
bump-sentieon
branch
from
September 17, 2026 19:46
9d1dfe5 to
84e38cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all sentieon modules to version 202503.03.
Note:
dockerprofile and fail when usingsingularityprofile).sentieon/rsemcalculateexpression, the linter raises anInvalid 'meta' keys detected: meta.strandednesserror. I tried to overcome this issue by makingstrandednessan optional input value channel, and updated the tests accordingly; however, this adjustment broke a subworkflow that leverages onsentieon/rsemcalculateexpression. After asking for suggestions, I rolled-back the changes and leftstrandednessa meta attribute.sentieon/rsemcalculateexpression's docker and singularity containers are built using the same environment.yml definition,sentieon/rsemcalculateexpression's tests remain flaky, with docker/conda profile tests producing a different snapshot (see here) than the one produced by the singularity profile (see here).PR checklist
nf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda