Added support for Cleanifier tool: cleanifier/download, cleanifier/index and cleanifier/filter#12360
Added support for Cleanifier tool: cleanifier/download, cleanifier/index and cleanifier/filter#12360LeonHornich wants to merge 1 commit into
Conversation
|
I would suggest to split this up into one PR by subtool / command :) regarding the md5sum instability I will add a comment |
There was a problem hiding this comment.
We want the ext.args to be present in the main.nf.test file. That makes everything more readable in one go. See the module specifications for more info.
There was a problem hiding this comment.
You can run
nextflow lint -format -sort-declarations -spaces 4 -harshil-alignmenton this file to clean this up nicely.
There was a problem hiding this comment.
Please remove this file :)
| @@ -0,0 +1,5 @@ | |||
| process { | |||
| withName: CLEANIFIER_INDEX { | |||
| ext.args = "-k 31" | |||
There was a problem hiding this comment.
We want the ext.args to be present in the main.nf.test file. That makes everything more readable in one go. See the module specifications for more info.
| """ | ||
| } | ||
| } | ||
|
|
||
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot(sanitizeOutput(process.out)).match() } | ||
| { assert snapshot(process.out).match() } |
There was a problem hiding this comment.
I would just first assert the txt content of the filter output and then we can probably see why the md5sum is instable
| { assert snapshot(process.out).match() } | |
| { assert snapshot( | |
| path(process.out.filter[0][1]).readLines(), | |
| process.out.info, | |
| process.out.findAll { key, val -> key.startsWith("versions") }, | |
| ).match() } |
With this PR I want to add support for the Cleanifier tool for species contamination removal. There are 3 added modules: download, index and filter.
Unfortunately I am still experiencing some issues with nf-test snapshot stability. If anyone has an idea on how to fix them i'd very much appreciate that. Of course other feedback is also highly appreciated.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda