Skip to content

Stranger - #133

Merged
nvnieuwk merged 11 commits into
nf-cmgg:devfrom
gustav-001:stranger
Sep 9, 2026
Merged

Stranger#133
nvnieuwk merged 11 commits into
nf-cmgg:devfrom
gustav-001:stranger

Conversation

@gustav-001

Copy link
Copy Markdown
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • Parameters Documentation is updated with nf-core schema docs --format markdown --output docs/parameters.md --force
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Description

Adds Stranger to the repeat-expansion subworkflow, annotating ExpansionHunter's calls with pathogenicity classification taken from the variant catalog.

Changes

  • EXPANSIONHUNTER → BCFTOOLS_ANNOTATE → TABIX_TABIX becomes EXPANSIONHUNTER → BCFTOOLS_ANNOTATE → STRANGER
  • TABIX_TABIX is removed as Stranger emits its own .tbi.
  • The catalog channel take is reused.
  • ext.prefix is necessary, otherwise the module errors due to matching in- and output filenames.

Issues

  • This was tested with a local copy of a modified variant_catalog.json file with the necessary fields for Stranger. This file is not live on the test-datasets repo. The new variant_catalog_stranger.json can be used as input for ExpansionHunter as additional fields are ignored.

…hangelog. Added extra section to ExpansionHunter in output.md about Stranger.
Add STRANGER to BAM_REPEAT_ESTIMATION_EXPANSIONHUNTER|

TABIX_TABIX is removed from the subworkflow as Stranger emits its own tabix files.
Comment thread subworkflows/local/bam_repeat_estimation_expansionhunter/main.nf
@nvnieuwk

nvnieuwk commented Sep 7, 2026

Copy link
Copy Markdown
Member

Allright! Still some broken tests that need to be fixed though

@gustav-001

Copy link
Copy Markdown
Collaborator Author

Allright! Still some broken tests that need to be fixed though

Some tests are failing due to the variant catalog file not having the required fields for Stranger. I opened a PR for this on the tests-datasets repo. Can you check that one out? Thanks

@nvnieuwk

nvnieuwk commented Sep 8, 2026

Copy link
Copy Markdown
Member

Approved and merged!

@nvnieuwk nvnieuwk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

@nvnieuwk
nvnieuwk merged commit ab41fff into nf-cmgg:dev Sep 9, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants