Stranger - #133
Merged
Merged
Conversation
…hangelog. Added extra section to ExpansionHunter in output.md about Stranger.
Add STRANGER to BAM_REPEAT_ESTIMATION_EXPANSIONHUNTER| TABIX_TABIX is removed from the subworkflow as Stranger emits its own tabix files.
nvnieuwk
reviewed
Sep 7, 2026
Member
|
Allright! Still some broken tests that need to be fixed though |
Collaborator
Author
Some tests are failing due to the variant catalog file not having the required fields for Stranger. I opened a PR for this on the tests-datasets repo. Can you check that one out? Thanks |
Member
|
Approved and merged! |
…g.json to variant_catalog_stranger.json
…ed to the versions block
…ted some whitespaces
…nged` on same version of nf-core as .nf-core.yaml (nf-core:3.5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.nf-core schema docs --format markdown --output docs/parameters.md --forceCHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).Description
Adds Stranger to the repeat-expansion subworkflow, annotating ExpansionHunter's calls with pathogenicity classification taken from the variant catalog.
Changes
EXPANSIONHUNTER → BCFTOOLS_ANNOTATE → TABIX_TABIXbecomesEXPANSIONHUNTER → BCFTOOLS_ANNOTATE → STRANGERTABIX_TABIXis removed as Stranger emits its own.tbi.takeis reused.ext.prefixis necessary, otherwise the module errors due to matching in- and output filenames.Issues
variant_catalog.jsonfile with the necessary fields for Stranger. This file is not live on thetest-datasetsrepo. The newvariant_catalog_stranger.jsoncan be used as input for ExpansionHunter as additional fields are ignored.