Skip to content

fix(studio): split soundtrack preview into music/narration + fix Windows asset path #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
walliai666 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(studio): split soundtrack preview into music/narration + fix Windows asset path #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/studio-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,7 +1388,7 @@ export async function startStudioServer(ctx: CliContext, port: number): Promise<
return res.end('missing ?path');
}
const safe = resolve(p);
if (!safe.includes('/.html-video/projects/')) {
if (!safe.replace(/\\/g, '/').includes('/.html-video/projects/')) {
res.writeHead(403);
return res.end('forbidden');
}
Expand Down
36 changes: 27 additions & 9 deletions packages/project-studio/public/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,7 @@ function renderMain() {
<button class="st-generate" id="btn-st-gen-music">${t('soundtrack.gen_music')}</button>
<span class="st-status" id="st-music-status"></span>
</div>
<div class="soundtrack-preview" id="st-music-preview"></div>
</div>

<!-- ===== Narration / voiceover ===== -->
Expand Down Expand Up @@ -842,13 +843,13 @@ function renderMain() {
<button class="st-generate" id="btn-st-gen-narration">${t('soundtrack.gen_narration')}</button>
<span class="st-status" id="st-narration-status"></span>
</div>
<div class="soundtrack-preview" id="st-narration-preview"></div>
</div>
</div>

<div class="soundtrack-actions">
<button class="st-clear" id="btn-st-clear">${t('soundtrack.clear')}</button>
</div>
<div class="soundtrack-preview" id="st-preview"></div>
</div>
</details>
</section>
Expand Down Expand Up @@ -925,7 +926,8 @@ function wireSoundtrackPanel() {
const clearBtn = document.getElementById('btn-st-clear');
const musicStatusEl = document.getElementById('st-music-status');
const narrationStatusEl = document.getElementById('st-narration-status');
const previewEl = document.getElementById('st-preview');
const musicPreviewEl = document.getElementById('st-music-preview');
const narrationPreviewEl = document.getElementById('st-narration-preview');
const draftFrameBtn = document.getElementById('btn-st-draft-frame');
const draftAllBtn = document.getElementById('btn-st-draft-all');
const whichEl = document.getElementById('st-narration-which');
Expand Down Expand Up @@ -1079,7 +1081,8 @@ function wireSoundtrackPanel() {
await fetch(`/api/projects/${state.selected.id}/soundtrack`, { method: 'DELETE' });
musicPrompt.value = '';
narrationText.value = '';
previewEl.innerHTML = '';
if (musicPreviewEl) musicPreviewEl.innerHTML = '';
if (narrationPreviewEl) narrationPreviewEl.innerHTML = '';
if (musicStatusEl) musicStatusEl.textContent = '';
if (narrationStatusEl) narrationStatusEl.textContent = '';
if (state.selected) delete state.selected.soundtrack;
Expand Down Expand Up @@ -1165,19 +1168,34 @@ function wireSoundtrackPanel() {
}

function renderSoundtrackPreview(soundtrack) {
const previewEl = document.getElementById('st-preview');
if (!previewEl || !soundtrack || !state.selected) return;
if (!soundtrack || !state.selected) return;
const assets = state.selected.assets || [];
const srcFor = (id) => {
const a = assets.find((x) => x.id === id);
return a?.path ? `/asset?path=${encodeURIComponent(a.path)}` : null;
};
const blocks = [];
const musicPreviewEl = document.getElementById('st-music-preview');
const narrationPreviewEl = document.getElementById('st-narration-preview');
const legacyPreviewEl = document.getElementById('st-preview');
const musicSrc = soundtrack.musicAssetId && srcFor(soundtrack.musicAssetId);
const narrSrc = soundtrack.narrationAssetId && srcFor(soundtrack.narrationAssetId);
if (musicSrc) blocks.push(`<div class="st-track"><span>${t('soundtrack.music_ready')}</span><audio controls src="${musicSrc}"></audio></div>`);
if (narrSrc) blocks.push(`<div class="st-track"><span>${t('soundtrack.narration_ready')}</span><audio controls src="${narrSrc}"></audio></div>`);
previewEl.innerHTML = blocks.join('');
if (musicPreviewEl) {
musicPreviewEl.innerHTML = musicSrc
? `<div class="st-track"><span>${t('soundtrack.music_ready')}</span><audio controls src="${musicSrc}"></audio></div>`
: '';
}
if (narrationPreviewEl) {
narrationPreviewEl.innerHTML = narrSrc
? `<div class="st-track"><span>${t('soundtrack.narration_ready')}</span><audio controls src="${narrSrc}"></audio></div>`
: '';
}
// Compatibility: if the old single preview container still exists, render both.
if (legacyPreviewEl) {
const blocks = [];
if (musicSrc) blocks.push(`<div class="st-track"><span>${t('soundtrack.music_ready')}</span><audio controls src="${musicSrc}"></audio></div>`);
if (narrSrc) blocks.push(`<div class="st-track"><span>${t('soundtrack.narration_ready')}</span><audio controls src="${narrSrc}"></audio></div>`);
legacyPreviewEl.innerHTML = blocks.join('');
}
}

// ============== composer attachments ==============
Expand Down