fix Codex invocation lifecycle handling - #149
Open
jhinzzz wants to merge 1 commit into
Open
Conversation
nettee
approved these changes
Sep 4, 2026
nettee
left a comment
There was a problem hiding this comment.
I reviewed the Codex JSONL lifecycle parsing, model-catalog stderr redaction, and conversion terminal-state handling across every changed range. I also verified the full application suite (190 tests), TypeScript check, and repository guard locally. Thanks for the focused regression coverage and clear failure behavior—nice work tightening this boundary.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Why
Codex JSONL sessions can emit lifecycle events and a nonfatal model-catalog diagnostic before the assistant output. The adapter ignored the start events, forwarded the full diagnostic response body, and the browser marked any ended stream as done even when the process failed or produced no HTML.
What changed
Provider and model selection remain inherited from the existing Codex CLI environment. This change adds no provider-specific configuration.
Validation
pnpm -F @html-anything/next test— 24 files, 190 tests passedpnpm -F @html-anything/next typecheckpnpm exec tsx scripts/guard.tspnpm -F @html-anything/next buildcodex exec --jsonHTML smoke — exit 0Redacted real-session log:
Only event types are included; stderr payloads and generated content are intentionally omitted.