Repository navigation
chore: add local commit checks and share qualification setup - #94
Merged
Merged
Conversation
JJLiebig
force-pushed
the
chore/local-precommit-20261014
branch
from
October 14, 2026 19:40
e2196a2 to
c34acba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds whole-tree local commit checks for formatting, full lint, the supply-chain watchlist, LOC budgets, and package/playground/E2E source types.
just setuporjust hooks-installactivates the tracked hook without replacing custom hooks. Commit checks use installed tools and do not download, format, stage, stash, or rebuild files.Qualification now shares the existing Ubuntu/Node setup: full runs retain Quality, deploy runs retain correctness lint, and both keep TypeScript, packed-package and browser qualification. The
Correctness / Package and browserandQualification resultnames remain. Main has no configured branch protection or rulesets requiring the former standalone Quality status.Runtime validation on e2196a2 (unchanged runtime files at final head):
just quality, full lint/watchlist, source types and formatting passed. Real Git commit rejects a formatted unstaged lint error; direct Git hook leaves source and raw index unchanged. A missing installed formatter fails in 1.20s.Packed-consumer/browser replay was not rerun locally: product behavior is unchanged and these gates remain in CI. Final head uses the user-approved local fallback because hosted CI is overloaded; hosted qualification is not passed. No local/shared/global Git hook configuration was changed during verification.
Final head: c34acba. The only follow-up change synchronizes the approved Meta-managed AGENTS block, preserving repository-specific text byte-for-byte. Exact-block comparison and diff checks passed; independent documentation review found no issues at tree 91f175bf6d9f2524e873f22b2198c6568116738c. Runtime checks were reused; the documentation amend uses [skip ci].
Hosted-failure diagnosis: run 38625133499 on runtime head e2196a2 completed with 50/51 passing, including packed-package and tooling acceptance. The only failure was mobile keyboard selection in tests/controls.e2e.ts: Delivery region remained Select instead of Americas. Quality and typecheck passed. Exact base main b82f5a0 had passed51/51 in run38599885026 with the same Chromium1243. App, package, tests, E2E configuration, dependencies and lockfile are unchanged by this PR. Artifact timing shows the test sends Home/ArrowDown/Enter within9ms after listbox visibility without waiting for option focus; installed BaseUI queues initial focus through requestAnimationFrame. This supports a pre-existing focus-readiness race; direct Linux reproduction was not obtained. Additional focused CI-mode local runs (retries0, model0) passed10/10 for this candidate and10/10 for exact-main baseline. No introduced source/workflow defect was identified, and no retry, sleep, gate bypass or unrelated product/test change was added. Hosted full qualification remains failed, not passed.
Authorized focused Linux fallback completed on exact final head c34acba, without changing product/test/cache files: Node26.9.0, npm12.0.2, frozen lockfile, Chromium153.0.8010.12/revision1243 in a disposable local Debian container. Native command: CI=1 e2e run tests/controls.e2e.ts --target mobile --grep 'keyboard controls expose validation and restore dialog focus' --repeat-each 10 --retries 0. Result10/10 passed,10.80s, zero model calls/tokens, run01a13bfd-719f-7465-968e-a17481ce2216. Full package/playground build also passed in Linux. Combined with the unchanged runtime-head hosted50/51 successes, this supplies the previously missing journey proof under the approved local fallback; it does not relabel the hosted run as passing. No introduced defect was identified; the exact cause of the intermittent hosted focus failure remains inferred. Linux report SHA256127E607037A4EE4E2B668C5E64AC185057F8C54DA83F895D9293EAA11975F1FC. Container removed after completion; no host/distro/global tooling settings changed.