Repository navigation
chore: adopt Vite+ tooling and native lint parity - #91
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the approved Meta PR #47 toolchain in the existing npm workspace: Node 26.9.0, npm 12.0.2, Vite+ 1.1.0/core 1.1.0/Vitest 5.0.3 and TypeScript 7.0.2. Prettier and native TesterArmy remain the formatter and acceptance runner. No product source, package version, recordings or unrelated dependency upgrades change.
Preserves both workspace lint policies, accessibility exceptions and Quality/Correctness separation. Native Oxlint replaces ESLint execution; the official Hooks plugin retains purity/config/gating where parity needs it. Both old scopes lacked typed unsafe/promise rules, so this PR retains that scope and explicit TS7 checking.
vp packpreserves the public unbundled.js/.d.tsexports, styles/fonts and all 19 client directives. Publication stays manual, tag-bound and separately qualified.Candidate:
8e033855b6fba6b171c61c63674a18faf0611dcb.055c28d937d4c28fbce5b946c19c702d0694fe32; its Git tree exactly matches the candidate (c92f78f1782d329e256cf1646cf49f6abbe2abec).npm ci,just quality, TS7 workspace/test/tool checks, both builds and isolated tarball consumer pass. Packed consumer proves runtime/type imports, assets and existing regressions; 37.65s.Review Suite normal
rvw_d022e473: accepted P2 fixture-isolation fix is validated with unchanged coverage; local ladder and bounded cleanup pass are clean; anchored GitHub review is clean on the exact candidate. Lint probes now use ignored, compiler-excluded scratch paths outside package source.Known tool notices remain visible: experimental TS7 declaration API, conservative Rolldown directive warnings (emitted directives verified), and existing playground chunk-size/LOC warnings. No macOS runtime claim. Details:
docs/viteplus-migration.md.Parent integration owns merge. No tag, publication or deployment is performed by this PR.