fix(settings): clean up regex / app config outliers - #63745
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
`mail_general_settings` is a historical HTML fragment identifier used to link to the email server settings. It is not a core app config key and therefore does not belong in `getAuthorizedAppConfig()`. Email server settings use system configuration and are authorized through their dedicated settings controller. Signed-off-by: Josh <josh.t.richards@gmail.com>
Replace the invalid regex-like app config entry with explicit keys for sendpasswordmail and replyToInitiator. Signed-off-by: Josh <josh.t.richards@gmail.com>
Better match intent; no practical operational change today. Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
approved these changes
Aug 31, 2026
Member
|
/backport to stable34 |
Member
|
/backport to stable35 |
Member
|
/backport to stable33 |
marcelklehr
approved these changes
Sep 1, 2026
joshtrichards
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Broader follow-up inspired by #63686 that cleans up some other outliers.
core/mail_general_settingsauthorization entry.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)