fix(SchemaChecker): replay migrations for disabled apps in 'expected' schema - #63701
Open
Antreesy wants to merge 3 commits into
Open
fix(SchemaChecker): replay migrations for disabled apps in 'expected' schema#63701Antreesy wants to merge 3 commits into
Antreesy wants to merge 3 commits into
Conversation
Antreesy
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
August 27, 2026 09:48
Antreesy
added
3. to review
Antreesy
changed the title
Merged
4 tasks
Antreesy
force-pushed
the
fix/63351/schema-checker-disabled
branch
from
August 31, 2026 13:57
172d8ce to
c354f8e
Compare
- otherwise tables from disabled apps rendered as 'unexpected' - should only be true for actually removed apps - do not exit with 1 if there are only findings in disabled apps Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/63351/schema-checker-disabled
branch
from
August 31, 2026 14:09
c354f8e to
6693ef0
Compare
come-nc
reviewed
Sep 1, 2026
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- db:schema:check now prints disabled-app findings only with -v. - Upgrade no longer reports disabled-app schema drift at all. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
come-nc
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also replay migrations for disabled apps
⚠️ Only in expected schema, it's a dry run, no live db is touched
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)