feat(neon_framework): queue for request manager to limit parallel req… - #3184
feat(neon_framework): queue for request manager to limit parallel req…#3184vauvenal5 wants to merge 2 commits into
Conversation
1b86360 to
19674e5
Compare
19674e5 to
53e104e
Compare
|
Can you check the test results and try to reproduce locally? I think they could be related. |
53e104e to
18f9b60
Compare
|
I have to look deeper into this but I believe it is a timing issue. The bigger the delay in the test the more refresh calls pass and the expected amount does not match anymore. I guess my changes lead the more calls passing but not sure yet of the details. |
18f9b60 to
2d17495
Compare
|
Okay I believe I have narrowed it down. There are actually 5 events which call
Due to the timing it does not show up in the test until you set a sleep also after the the refresh call in the test: My change seems to every slightly switch timing making all calls finish before the verify gets triggered in the test. I refactored the test a bit making the behavior more deterministic. |
…uests to server Signed-off-by: vauvenal5 <vauvenal5.ndgme@slmails.com>
2d17495 to
9a60b0b
Compare
Signed-off-by: vauvenal5 <vauvenal5.ndgme@slmails.com>
c1ad79f to
5aa811f
Compare
Limits the amount of parallel requests to the server to not overload it with preview requests when opening a big gallery and scrolling through it.
As agreed in #1124 this is a first step.