fix(whitelisting): Never treat the empty app id as whitelisted - #1666
Merged
Conversation
CarlSchwan
approved these changes
Aug 21, 2026
CarlSchwan
enabled auto-merge
August 21, 2026 08:21
WHITELIST_ALWAYS started with a comma, so exploding it produced an empty
first entry and isAppWhitelisted('') returned true. getRequestedApp()
returns an empty string whenever IAppManager::cleanAppId() strips the
path segment down to nothing, which made those requests pass the
allowlist check.
Config::getAppWhitelist() had the same problem: exploding an empty
setting yields a single empty entry, which was both whitelisted and
rendered as a blank chip in the admin settings.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
CarlSchwan
force-pushed
the
fix/empty-app-id-whitelist
branch
from
August 21, 2026 08:32
a90f12b to
0c2856a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHITELIST_ALWAYS started with a comma, so exploding it produced an empty first entry and isAppWhitelisted('') returned true. getRequestedApp() returns an empty string whenever IAppManager::cleanAppId() strips the path segment down to nothing, which made those requests pass the allowlist check.
Config::getAppWhitelist() had the same problem: exploding an empty setting yields a single empty entry, which was both whitelisted and rendered as a blank chip in the admin settings.