Skip to content

fix(tests): use correct locator for form settings #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chartman123 merged 1 commit into from
Oct 11, 2026
+5 −13
Merged

fix(tests): use correct locator for form settings #3750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions playwright/e2e/form-settings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,12 @@ test.describe('Form settings', () => {
await page.getByRole('button', { name: /Share/ }).click()
const settingsTab = page.getByRole('tab', { name: /Settings/ })
await settingsTab.click()
await expect(
page.getByRole('checkbox', { name: /Close form/ }),
).toBeVisible()
await expect(page.getByRole('switch', { name: /Close form/ })).toBeVisible()
})

test('Closing a form blocks submissions', async ({ page, topBar }) => {
const saved = waitForApiResponse(page, 'PATCH')
await page
.getByRole('checkbox', { name: /Close form/ })
.click({ force: true })
await page.getByRole('switch', { name: /Close form/ }).click({ force: true })
await saved

await topBar.toggleView(FormsView.View)
Expand All @@ -67,16 +63,12 @@ test.describe('Form settings', () => {
}) => {
// Close the form
const closed = waitForApiResponse(page, 'PATCH')
await page
.getByRole('checkbox', { name: /Close form/ })
.click({ force: true })
await page.getByRole('switch', { name: /Close form/ }).click({ force: true })
await closed

// Reopen the form
const reopened = waitForApiResponse(page, 'PATCH')
await page
.getByRole('checkbox', { name: /Close form/ })
.click({ force: true })
await page.getByRole('switch', { name: /Close form/ }).click({ force: true })
await reopened

await topBar.toggleView(FormsView.View)
Expand All @@ -91,7 +83,7 @@ test.describe('Form settings', () => {
}) => {
const saved = waitForApiResponse(page, 'PATCH')
await page
.getByRole('checkbox', { name: /Store responses anonymously/ })
.getByRole('switch', { name: /Store responses anonymously/ })
.click({ force: true })
await saved

Expand Down
Loading