Repository navigation
Base form expiration on server time - #3599
OllieinCanada wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
performance.now(), keeping expiration checks independent of the client's wall clock even if it changes after page loadRationale
The backend already decides expiration with server time, but the frontend compared
form.expireswithmoment().unix(). A client clock set in the future could therefore hide a form that the server still considers active. Anchoring a monotonic timer to the server timestamp keeps the UI consistent with backend authorization without repeated network requests.Validation
git diff --checkFixes #3598