Repository navigation
fix: stop viewport wobble in submit/view mode - #3580
xhon-pelushi wants to merge 1 commit into
Conversation
|
@xhon-pelushi please correctly sign-off your commit :) |
Fixes nextcloud#2810 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
9c96856 to
11ad683
Compare
|
Thanks @Chartman123 — added a |
|
@xhon-pelushi did you test this? I just tried it in my dev instance and there's no change regarding the wobble |
|
@Chartman123 thanks for testing this on a real instance. I tried to reproduce the remaining wobble before replying but couldn't get a conclusive result — I don't have a live Nextcloud instance with Forms available to me right now (my usual quick option, a fresh instant-trial, doesn't come with Forms installed and I only have a non-admin account there, so I can't enable it). While digging into it statically, I found a second possible contributor unrelated to this PR's header fix: Could you share a couple more details so I can pin it down properly instead of guessing:
That would let me confirm whether it's the |
|
Please set up a real dev environment. Closing this PR. |
|
@Chartman123 fair enough — I set one up. Wanted to follow through with actual evidence rather than more back-and-forth. Ran a real Nextcloud Measuring the actual
So the header math in this PR is confirmed correct against a real render, not just isolated CSS. If there's a different wobble you're seeing beyond this (a different element, a different viewport/browser), I'm glad to chase that too — just let me know the width/browser and, if you have a second, whether Chrome/Firefox DevTools' Layout panel flags a different element as the culprit. Would you be up for reopening this? I don't have permission to do it myself. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Prevent viewport wobble on published forms.
Fixes #2810
Test plan