fix: Normalisation of Windows paths during journal clean-up after recursive deletion - #10692
Open
claucambra wants to merge 3 commits into
Open
fix: Normalisation of Windows paths during journal clean-up after recursive deletion#10692claucambra wants to merge 3 commits into
claucambra wants to merge 3 commits into
Conversation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…lback for use in journal cleanup Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
claucambra
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
August 29, 2026 04:41
Collaborator
Author
|
/backport to stable-34.0 please |
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
claucambra
force-pushed
the
work/normalisation-callback
branch
from
August 29, 2026 06:32
2f761ac to
69233b0
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10692.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, recursive deletion callbacks used absolute
\-separated paths, while journal entries use relative/-separated paths. The old prefix comparison therefore failed. Successfully deleted items could remain in the journal and later be misinterpreted as user deletions, causing unintended remote deletion.This fix normalises callback paths with Qt, converts them to validated journal-relative paths before cleanup, and uses component-aware directory matching.
Checklist
AI (if applicable)