Skip to content

Mark as compatible with NC35 - #3324

Merged
christianlupus merged 4 commits into
masterfrom
maintenance/nc35
Aug 25, 2026
Merged

Mark as compatible with NC35#3324
christianlupus merged 4 commits into
masterfrom
maintenance/nc35

Conversation

@christianlupus

Copy link
Copy Markdown
Collaborator

Topic and Scope

This PR marks the app as compatible with the upcoming NC 35.

Concerns/issues

It is not thoroughly tested yet but unit tests should check most cases

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus

Copy link
Copy Markdown
Collaborator Author

Current tests will fail as the stable35 branch does not yet exist.

@christianlupus

Copy link
Copy Markdown
Collaborator Author

/approve

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Test Results

   11 files    583 suites   2m 16s ⏱️
  589 tests   581 ✅  8 💤 0 ❌
2 344 runs  2 311 ✅ 33 💤 0 ❌

Results for commit cca26b0.

♻️ This comment has been updated with latest results.

@christianlupus
christianlupus marked this pull request as ready for review August 25, 2026 16:01
The foreign key constraints prevent the default removal of the tables one by one.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
christianlupus merged commit 9e896b8 into master Aug 25, 2026
20 checks passed
@christianlupus
christianlupus deleted the maintenance/nc35 branch August 25, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants