Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/Controller/LocalController.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\Attribute\BruteForceProtection;
use OCP\AppFramework\Http\Attribute\NoAdminRequired;
use OCP\AppFramework\Http\Attribute\UserRateLimit;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Http\FileDisplayResponse;
use OCP\AppFramework\OCS\OCSException;
Expand Down Expand Up @@ -70,6 +71,7 @@ public function __construct(
}

#[NoAdminRequired]
#[UserRateLimit(limit: 10, period: 60)]
public function create(string $name, bool $personal = false, bool $local = false): DataResponse {
try {
if (!$this->configService->isGSAvailable() && $local === true) {
Expand Down
13 changes: 13 additions & 0 deletions lib/Exceptions/CircleNameTooLongException.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

/**
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\Circles\Exceptions;

class CircleNameTooLongException extends FederatedItemBadRequestException {
}
4 changes: 4 additions & 0 deletions lib/FederatedItems/CircleEdit.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use OCA\Circles\Db\CircleRequest;
use OCA\Circles\Db\MemberRequest;
use OCA\Circles\Exceptions\CircleNameTooLongException;
use OCA\Circles\Exceptions\CircleNameTooShortException;
use OCA\Circles\Exceptions\RequestBuilderException;
use OCA\Circles\IFederatedItem;
Expand Down Expand Up @@ -49,6 +50,7 @@ public function __construct(
*
* @throws RequestBuilderException
* @throws CircleNameTooShortException
* @throws CircleNameTooLongException
*/
public function verify(FederatedEvent $event): void {
$circle = $event->getCircle();
Expand All @@ -63,6 +65,8 @@ public function verify(FederatedEvent $event): void {
$new->setName($this->circleService->cleanCircleName($data->g('name')));
if (strlen($new->getName()) < 3) {
throw new CircleNameTooShortException('Circle name is too short');
} elseif (strlen($new->getName()) > 127) {
throw new CircleNameTooLongException('Circle name is too long');
}
$event->getData()->s('name', $new->getName());
}
Expand Down
3 changes: 3 additions & 0 deletions lib/Service/CircleService.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use OCA\Circles\AppInfo\Application;
use OCA\Circles\Db\CircleRequest;
use OCA\Circles\Db\MemberRequest;
use OCA\Circles\Exceptions\CircleNameTooLongException;
use OCA\Circles\Exceptions\CircleNameTooShortException;
use OCA\Circles\Exceptions\CircleNotFoundException;
use OCA\Circles\Exceptions\FederatedEventException;
Expand Down Expand Up @@ -146,6 +147,8 @@ public function create(

if (strlen($circle->getName()) < 3) {
throw new CircleNameTooShortException('Circle name is too short');
} elseif (strlen($circle->getName()) > 127) {
throw new CircleNameTooLongException('Circle name is too long');
}

if ($personal) {
Expand Down
Loading