Skip to content

feat(haproxyinstance): promote Span-based synthesis rule to production - #3223

Open
gmanandhar-nr wants to merge 1 commit into
newrelic:mainfrom
gmanandhar-nr:haproxy-promote-span-synthesis-to-prod-v2
Open

gmanandhar-nr wants to merge 1 commit into
newrelic:mainfrom
gmanandhar-nr:haproxy-promote-span-synthesis-to-prod-v2

Conversation

@gmanandhar-nr

Copy link
Copy Markdown
Contributor

This is simply updating the staging rules to production!

Add infra_haproxyinstance_otel_span rule that maps HAProxy OTel filter trace spans to the HAPROXYINSTANCE entity using the same host.id:haproxy.addr composite identifier as existing Metric rules. This enables distributed tracing relationships (CALLS) between application services and HAProxy.

  • Promote staging span synthesis rule to definition.yml
  • Remove definition.stg.yml (now identical to production)
  • Promote Span.stg.json test fixture to Span.json

Relevant information

Api Review Board (ARB)

Pull requests with changes to this repository might need to be linked with an ARB ticket, which has to be approved before merging.

If you are an external contributor please contact New Relic Support.

What definition changes require ARB and which do not? Guide here.

If you are new to ARB process also check this.

ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-XXXX

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.
  • I've linked an ARB ticket & received approval from API Review Board in order to make these changes

Add infra_haproxyinstance_otel_span rule that maps HAProxy OTel filter
trace spans to the HAPROXYINSTANCE entity using the same host.id:haproxy.addr
composite identifier as existing Metric rules. This enables distributed
tracing relationships (CALLS) between application services and HAProxy.

- Promote staging span synthesis rule to definition.yml
- Remove definition.stg.yml (now identical to production)
- Promote Span.stg.json test fixture to Span.json

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot
entityBot requested a review from a team September 6, 2026 16:31

@shashank-reddy-nr shashank-reddy-nr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@entityBot
entityBot requested a review from a team September 7, 2026 07:07
# using the same host.id:haproxy.addr composite identifier as the Metric rules.
# This ensures traces and metrics resolve to the same entity.
# Requires: resourcedetection processor (adds host.id) + resource processor (adds haproxy.addr)
- ruleName: infra_haproxyinstance_otel_span

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is the only rule that explicitly omits instrumentation.provider: opentelemetry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants