Repository navigation
Conversation
The bot ran 'go get -u <base>@main', and -u upgrades the dependency closure of the named package, not just the named module. A lint-config-only change in vpphelper therefore bumped go.fd.io/govpp v0.11.0 -> v0.13.0 in cmd-forwarder-vpp, together with logrus, testify, fsnotify and x/sys, under a PR titled "Update from update/networkservicemesh/vpphelper". govpp v0.13.0 carries an Unsubscribe() regression that panics VPP components with "send on closed channel", which broke integration-k8s-kind CI. No module required v0.13.0. Dropping -u makes the bot move only the intended module. 'go get M@main' still updates the requirement and still raises dependencies the new version genuinely requires. Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dependent-repository update bot upgrades unrelated third-party
dependencies as a side effect of bumping an NSM module, with no signal in the
PR title. This just broke integration-k8s-kind CI for days.
What happened:
vpphelpermerged77eb5fca, which changed only.golangci.ymland.github/workflows/ci.yaml. Itsgo.modwas untouched and it still requiresgo.fd.io/govpp v0.11.0.That push fanned out here, and this workflow ran
go get -u github.com/networkservicemesh/vpphelper@mainincmd-forwarder-vpp.The resulting PR, titled "Update from update/networkservicemesh/vpphelper",
bumped six dependencies, including
go.fd.io/govpp v0.11.0 -> v0.13.0:govpp v0.13.0 carries a regression in
subscriptionCtx.Unsubscribe()thatleaves a closed notification channel in
Connection.subscriptions, so thenext notification panics with
send on closed channel. Every VPP componentcrashlooped, and the automerged PR made it look like an NSM change.
Nothing in the dependency graph required v0.13.0:
vpphelperandnetworkservicemesh/govpprequire v0.11.0,sdk-vpprequires v0.10.0-alpha.The uplift came purely from
-u.Why
-udoes this-uupgrades the dependency closure of the packages named on the commandline, not just the named module.
vpphelperhas a root-level Go package, soits entire closure was upgraded.
sdk,sdk-vppandsdk-kernelkeep theircode under
pkg/, sogo get -u <them>@mainnames no package and produces onlya single-line module bump - which is why sdk-* updates never showed this
behaviour and this went unnoticed until a root-package base repo was touched.
Change
Drop
-u, so the bot moves only the module it is supposed to move:go get M@mainstill resolvesmainto the latest pseudo-version and updatesthe requirement, and still raises any dependency the new version genuinely
requires (MVS). It just stops volunteering unrelated upgrades.
go mod tidyisunchanged.
Trade-off (please review)
With
-u, these PRs doubled as a de facto "refresh all dependencies" job. Afterthis change, third-party dependencies advance only when something requires them
or Dependabot bumps them.
Dependabot coverage is not uniform today - e.g.
sdkandintegration-k8s-kindhave.github/dependabot.yml, whilecmd-forwarder-vppand
cmd-nsmgrdo not. If we want to keep dependencies moving, the follow-up isto add Dependabot to the repos that lack it, where bumps arrive as separate,
reviewable, correctly-titled PRs instead of hiding inside an NSM module bump.
Related occurrences (not changed here)
-uis used in two other shared workflows with the same failure mode. Left outof this PR to keep it reviewable, but worth deciding on:
.github/workflows/resolve-conflicts.yaml:58-go get -u github.com/networkservicemesh/${repository}@main(same operation asthis workflow, so arguably should match)
.github/workflows/release-dependent-repositories.yaml:64-go get -u $dep@${tag}, which can transitively uplift third-party deps duringa release
Fallout being cleaned up
v0.11.0. Basic suite went 6P/8F -> 14P/0F, Ipsec 0P/6F -> 6P/0F, and the
afxdp / ipv6 / heal-extended jobs went green.
cmd-nsc-vpp#798, cmd-nse-firewall-vpp#615, cmd-nse-vlan-vpp#630,
cmd-nse-icmp-responder-vpp#782, cmd-nse-simple-vl3-docker#343,
cmd-nsc-simple-docker#329.
Unsubscribe()regression is still present on govppmasterandneeds an upstream fix; one line - store the shrunk slice back into
conn.subscriptions[msgID].