Repository navigation
Bump golangci-lint-action to v7 and default linter to v2 - #100
Merged
Merged
Conversation
The previous change to golangci-lint-action@v6 is insufficient for
golangci-lint v2: the action hard-couples its major version to the linter
major version. v4/v6 support only golangci-lint v1, while v7 supports only
golangci-lint v2 and rejects v1 ("golangci-lint v1 is not supported by
golangci-lint-action v7"). With v6 pinned, a v2 linter-version fails with
"golangci-lint v2 is not supported by golangci-lint-action v6, you must
update to golangci-lint-action v7".
- Bump golangci/golangci-lint-action from v6 to v7.
- Bump the default linter-version from v1.64.2 to v2.13.2 so the action and
the default linter major versions are consistent.
NOTE: this is a hard cutover. Because v7 cannot run golangci-lint v1, every
repository using this reusable workflow must have a v2-format .golangci.yml
when this change lands. Repos are migrated with the accompanying
migrate-golangci-v2.sh tooling.
Assisted-by: Kiro (AI assistant)
Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change to golangci-lint-action@v6 is insufficient for golangci-lint v2: the action hard-couples its major version to the linter major version. v4/v6 support only golangci-lint v1, while v7 supports only golangci-lint v2 and rejects v1 ("golangci-lint v1 is not supported by golangci-lint-action v7"). With v6 pinned, a v2 linter-version fails with "golangci-lint v2 is not supported by golangci-lint-action v6, you must update to golangci-lint-action v7".
NOTE: this is a hard cutover. Because v7 cannot run golangci-lint v1, every repository using this reusable workflow must have a v2-format .golangci.yml when this change lands. Repos are migrated with the accompanying migrate-golangci-v2.sh tooling.