feat: Update for Neos 9#23
Draft
paxuclus wants to merge 6 commits into
Draft
Conversation
This removes the old yaml based configuration so only node based error pages can be used from now on
stephanschuler
approved these changes
Nov 4, 2024
# Conflicts: # Classes/Configuration/ErrorHandlerConfiguration.php # Classes/Configuration/NodeBasedConfiguration.php
NodeBasedConfiguration::getSiteNodes() silently found no error page configuration at all on installations with zero content dimensions configured, which is a valid and fairly common setup (single-locale sites). combineAllDimensionSpacePoints() only ever produced a result by combining pairs of dimension values, so with no dimensions the combination loop never ran and returned an empty set; the outer lookup then never yielded a single site node, and getConfiguration() came back completely empty with no error/warning of any kind (not even the --verbose per-site output). Also fixes two issues found while getting the zero-dimension case to actually run end-to-end: - VisibilityConstraints::frontend() doesn't exist on this neos/contentrepository-core version; replaced with the documented Neos-specific equivalent (NeosVisibilityConstraints::excludeRemoved() merged with ::excludeDisabled()). - findChildNodes() against the shared "Neos.Neos:Sites" root returns every site's node, not just the current one being iterated in the outer loop, so with N sites this reprocessed (and re-fetched/re-saved the error page for) each site N times over. Filtered to the matching child node name.
…sion NodeAggregate::getNodeByCoveredDimensionSpacePoint() doesn't exist on this neos/contentrepository-core version, which made errorpage:generate fail to resolve every configured error page's source URI. Per NodeAggregate's own documented usage, look the node up by first resolving the occupied origin for the covered dimension space point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the old yaml based configuration so only node based error pages can be used from now on